Ext4 crate replace #42
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Great！I will test it with pagecache soon. |
joey-shao
previously approved these changes
Jul 29, 2025
SMS-Derfflinger
requested review from
joey-shao
and removed request for
greatbridf and
joey-shao
Fix page cache's bug, add size check in read function. Add page cache's base operations for ext4, but the cachepage will not be dropped until kernel stop, so we need to call fsync function manually, consider use some strategy such as LRU.
Collaborator
Author
|
Add page cache's base operations for ext4, but the cachepage will not be dropped until kernel stop, so we need to call fsync function manually, consider use some strategy such as LRU. |
temporary write back by timer, when write function is called, check if the time since the last write back is greater than 10 seconds. If it is, then write back.
Collaborator
Author
|
Temporary write back by timer, when write function is called, check if the time since the last write back is greater than 10 seconds. If it is, then write back. |
greatbridf
previously approved these changes
Aug 16, 2025
joey-shao
approved these changes
Aug 16, 2025
Owner
|
On the previous version, we can see the 
While in the replaced implementation, the two are seen as regular files with 755 permission... 
This should be fixed and won't be hard... |
Collaborator
Author
This need a cargo update, because the another_ext4 updated, already done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace the previous ext4 crate that did not work well with another crate, now file and directory's read, write, create, delete operations are all worked well, this is done on the version without pagecache.